[PATCH] D73771: [AMDGPU] Don't remove short branches over kills

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 2 05:43:28 PST 2020


critson added a comment.

After some investigation the root cause of this appears to be that in some cases cbranch_execz instructions (relating to kills) are removed which leaves the SIInsertSkips pass unable to determine that a kill is being executed in branching control flow.  The result is that SIInsertSkips inserts skipIfDead code where it shouldn't because it is unaware the exec mask does not contain allow active threads.  This change is the least invasive solution, but the alternative would be to reengineer SIInsertSkips.  In either case this seems to be a blind spot in the skip-if-dead lit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73771/new/

https://reviews.llvm.org/D73771





More information about the llvm-commits mailing list