[PATCH] D73508: [LLD][COFF] Fix dll import for thread_local storage

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D73508#1846262 <https://reviews.llvm.org/D73508#1846262>, @mstorsjo wrote:

> In D73508#1846241 <https://reviews.llvm.org/D73508#1846241>, @zero9178 wrote:
>
> > I will look into it! I have not encountered the multiple definitions error when building with shared libraries.
>
>
> I don't remeber exactly which component it was in, it could have been in some component which isn't always built (maybe in some unit test, but I don't think I would have built those in that configuration anyway...) If it works fine for you (after fixing the TLS variable) I could give it another shot to see where I found issues.


I tested, and BUILD_SHARED_LIBS kind of worked, more or less, except for a few cases for which I've sent patches now.

The other thing I remembered was building with `-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON`; this fails pretty badly as it links both the big lib containing all of llvm, and the invidual libs, causing issues with duplication.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73508/new/

https://reviews.llvm.org/D73508