[PATCH] D73809: eSupport] Don't modify the current EH context during stack unwinding

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 1 07:08:32 PST 2020


aganea added a comment.

Thanks Reid for looking into this! So I suppose the problem is related to `llvm-symbolizer` not being invoked somehow in Stella's case? This seems to occur if either that exe is not in `%PATH%` or if `printSymbolizedStackTrace()` can't create the input/output files for symbolizer. Was that the bug?
And it looks like the llvm-symbolizer codepath already duplicates <https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/Windows/Signals.inc#L234> the `CONTEXT` like you do here, but then the fallback Dbghelp.dll doesn't duplicate, which most likely caused this issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73809/new/

https://reviews.llvm.org/D73809





More information about the llvm-commits mailing list