[PATCH] D73569: [LoopUtils] Make duplicate method a utility. [NFCI]

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 13:03:13 PST 2020


yamauchi added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1482
+                                 SmallPriorityWorklist<Loop *, 4> &Worklist) {
+  appendLoopsToWorklist(reverse(LI), Worklist);
+}
----------------
It seems like there's a double reverse for the LI version. I don't know if it'd be optimized away or would matter, but would there be a way to avoid double reverse? For example, by having a shared internal version of appendLoopsToWorklist which doesn't do any reversing internally and the RangeT version does a reverse before calling it and the LoopInfo version does no reverse?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73569/new/

https://reviews.llvm.org/D73569





More information about the llvm-commits mailing list