[PATCH] D73702: [WIP][mlir] enable conversion materialization for 1-1 type conversions

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.
Herald added a subscriber: Joonsoo.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:47
 
+/// Materializes the "load" operation from a pointer to a memref descriptor.
+/// This is used as a hook for type conversion.
----------------
ftynse wrote:
> rriddle wrote:
> > Do you intend for this to apply to PHI/non-entry Block arguments as well?
> Actually, no. Is there an easy way to differentiate here? Look at the owner of `pointer`?
I think we will likely need some kind of indicator on the context of the conversion, in this case a Region signature conversion for the given operation. Ideally the pattern doing the conversion would handle this, but I that doesn't really scale/isn't extensible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73702/new/

https://reviews.llvm.org/D73702