[PATCH] D73790: [AArch64][GlobalISel] Walk through G_AND in TB(N)Z bit calculation

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 10:26:56 PST 2020


paquette updated this revision to Diff 241766.
paquette marked an inline comment as done.
paquette added a comment.

- Be explicit about opcodes when looking for a constant.
- Add fixme to see if we can canonicalize where the constant shows up at a point earlier than selection.
- Some other refactoring to make the function a bit clearer.

(The case where the constant is on the other side does come up a couple times in the MultiSource tests at -O3.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73790/new/

https://reviews.llvm.org/D73790

Files:
  llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/opt-fold-and-tbz-tbnz.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73790.241766.patch
Type: text/x-patch
Size: 7031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200131/c9165c1b/attachment.bin>


More information about the llvm-commits mailing list