[PATCH] D73760: [X86] -fpatchable-function-entry=N,0: place patch label after ENDBR{32,64}

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 09:21:23 PST 2020


MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/X86/patchable-function-entry-ibt.ll:66
+
+define internal void @f1i() "patchable-function-entry"="1" {
+; CHECK-LABEL: f1i:
----------------
nickdesaulniers wrote:
> I think `@f1i` is missing the function attribute `"branch-target-enforcement"`?
x86 uses a module flag `"cf-protection-branch"`, instead of a function attribute.

Deleted the function attribute `"branch-target-enforcement"` attached to f0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73760/new/

https://reviews.llvm.org/D73760





More information about the llvm-commits mailing list