[PATCH] D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 17:18:48 PST 2020


rnk added a subscriber: vitalybuka.
rnk added a comment.

I think what you are doing is reasonable and practical. I only felt obligated to make the philosophical point that flaky tests are bad, and nobody other than the test owner should have to spend time on them.

In the meantime, I think this is pretty reasonable. Maybe @vitalybuka can help review it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73707/new/

https://reviews.llvm.org/D73707





More information about the llvm-commits mailing list