[PATCH] D73230: [X86][ELF] Prefer to lower MC_GlobalAddress operands to .Lfoo$local

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 17:09:09 PST 2020


MaskRay added a comment.

@craig.topper @rnk This is even safer than I thought.

  // clang/lib/CodeGen/CodeGenModule:shouldAssumeDSOLocal
    const auto &CGOpts = CGM.getCodeGenOpts();
    llvm::Reloc::Model RM = CGOpts.RelocationModel;
    const auto &LOpts = CGM.getLangOpts();
    if (RM != llvm::Reloc::Static && !LOpts.PIE)
      return false;

-fpic/-fPIC does not set `dso_local` so this change does not affect that compile model.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73230/new/

https://reviews.llvm.org/D73230





More information about the llvm-commits mailing list