[PATCH] D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:5307
   return materializeForwardReferencedFunctions();
 }
 
----------------
I think you need to call the new upgrade function from here as well.



================
Comment at: llvm/test/Bitcode/compatibility-5.0.ll:1256
   call void @f.strictfp() strictfp
-  ; CHECK: call void @f.strictfp() #44
+  ; CHECK: call void @f.strictfp() #9
 
----------------
It'd be nice to have a test that check that the callsite attribute isn't changed when used in a non-strictfp function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70096/new/

https://reviews.llvm.org/D70096