[PATCH] D73677: MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 13:26:19 PST 2020


xbolva00 added inline comments.


================
Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:63
+    message(FATAL_ERROR "Host Visual Studio version 19.24 is known to miscompile part of LLVM (use -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON to ignore)")
+  endif()
+endif()
----------------
add “Please upgrade to version 16.5+ or use clang-cl” ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73677/new/

https://reviews.llvm.org/D73677





More information about the llvm-commits mailing list