[PATCH] D73736: [mlir][ODS] Refactor BuildableType to use $_builder as part of the format

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 12:12:52 PST 2020


rriddle created this revision.
rriddle added a reviewer: antiagainst.
Herald added subscribers: llvm-commits, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, shauheen, burmako, jpienaar, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.

Currently BuildableType is assumed to be preceded by a builder. This prevents constructing types that don't have a callable 'get' method with the builder. This revision reworks the format to be like attribute builders, i.e. by accepting $_builder within the format itself.

Depends On D73735 <https://reviews.llvm.org/D73735>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73736

Files:
  mlir/include/mlir/IR/OpBase.td
  mlir/lib/TableGen/Type.cpp
  mlir/tools/mlir-tblgen/OpFormatGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73736.241541.patch
Type: text/x-patch
Size: 4841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200130/324c7cdd/attachment.bin>


More information about the llvm-commits mailing list