[PATCH] D73733: [mlir] [VectorOps] fixed bug in vector.insert_strided_slice lowering

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 11:35:18 PST 2020


aartbik created this revision.
Herald added subscribers: llvm-commits, liufengdb, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.
aartbik added reviewers: andydavis1, ftynse.

Rationale:
When lowering to LLVM for different rank insert (n vs k), the offset
arrays needs to drop one dimension (becomes n-1), but the strides
array needs to be preserved (remains k). With regression test.
Note that this example was actually in the documentation, so
extra important to do it right :-)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73733

Files:
  mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
  mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73733.241525.patch
Type: text/x-patch
Size: 19756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200130/d6225b34/attachment.bin>


More information about the llvm-commits mailing list