[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 10:31:24 PST 2020


SouraVX added a comment.

In D72828#1850038 <https://reviews.llvm.org/D72828#1850038>, @aprantl wrote:

> lgtm if David is happy.


Thank You, @aprantl, for your acceptance. I agree, that part of macro implementation needs refactoring/In my opinion/.  That was the reason, I was delaying and created separate patch for llvm-dwarfdump D73086 <https://reviews.llvm.org/D73086>. So that, even if we disagree/want changes, for a better implementation of dumping part.
We can still have emission part i.e this patch in LLVM {/tested/beneficial from consumer perspective GDB or LLDB/}


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828





More information about the llvm-commits mailing list