[PATCH] D73592: [IRCE] Make IRCE a Function pass.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 09:59:13 PST 2020


asbirlea added a comment.

Hi Max, please see https://groups.google.com/forum/#!topic/llvm-dev/pOMjqRYZRQ0. I didn't have an up-to-date email address, so the emails cc-ed to you bounced.

My main motivation is that we need BFI computed from scratch, as it's not being preserved. The new pass manager will disallow getting a cached analysis that can be invalidated, in order to avoid hidden bugs (happy to elaborate here).  This patch is rebased on top of D72891 <https://reviews.llvm.org/D72891>, which removes the `getCachedResult` for BFI.

I don't have the context for how IRCE is used, on its own or along with other loop passes, that's why I sent out the RFC, hoping to get some clarifications. Please also see the thread of making LoopUnrollAndJam a Function pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73592/new/

https://reviews.llvm.org/D73592





More information about the llvm-commits mailing list