[PATCH] D73554: [AIX] Don't use a zero fill with a second parameter

[David Tenty via Phabricator via llvm-commits]

daltenty marked 2 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:182
+  /// other than zero. Defaults to true.
+  bool ZeroDirectiveSupportsNonZeroValue = true;
+
----------------
jasonliu wrote:
> Have we consider rename the ZeroDirective to FillDirective and fix the comments there?
> Since this ZeroDirective did not convey what it really means.
> And this query is more like "FillDirectiveSupportsNonZeroFill".
That's not really quite right either. Fill directive seems to imply `.fill` which has different semantics again (and doesn't exist for the AIX assembler). And if a fill directive only supports zero's isn't it really a zero directive? So maybe there should actually be both? 

In any case I'm not sure how much we really want to dig into the naming issue for this patch. We'd likely have to make a fairly widespread change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73554/new/

https://reviews.llvm.org/D73554