[PATCH] D73710: [VE] vaarg functions callers and callees

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 08:32:16 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:328
+      .addMemOperand(MMO);
+  else if (RC == &VE::F32RegClass)
+    BuildMI(MBB, I, DL, get(VE::STUri))
----------------
Braces


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:353
+
+  if (RC == &VE::I64RegClass)
+    BuildMI(MBB, I, DL, get(VE::LDSri), DestReg)
----------------
Braces


================
Comment at: llvm/test/CodeGen/VE/va_arg2.ll:24
+
+  %a = alloca i8*, align 8
+  %b = alloca i8*, align 8
----------------
There's too much going on in one test function for my taste


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73710/new/

https://reviews.llvm.org/D73710





More information about the llvm-commits mailing list