[PATCH] D73711: [AArch64][SVE] Add support for DestructiveBinary and DestructiveBinaryComm DestructiveInstTypes

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 07:55:04 PST 2020


cameron.mcinally marked an inline comment as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:39
+def DestructiveTernaryCommWithRev : DestructiveInstTypeEnum<8>;
+
+class FalseLanesEnum<bits<2> val> {
----------------
Note that I took some liberties adding all the enumerators, even though most aren't used yet. I think it makes sense to put them in place now to avoid unnecessary churn later. There should be little risk since they are not currently used.

If anyone feels strongly about this, I will only add the tested enumerators...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73711/new/

https://reviews.llvm.org/D73711





More information about the llvm-commits mailing list