[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

Thu Jan 30 06:59:00 PST 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:159
+--- !ELF
+FileHeader: !FileHeader
+  Class: ELFCLASS32
----------------
jhenderson wrote:
> Delete "!FileHeader". It serves no purpose. You might want to do it for the other doc in this file in a separate change too.
You've deleted too much. I only wanted the bit after the ':' deleted. Please reinstate the `FileHeader:` part.

Does this work in its current state? That surprises me if it does.

================
Comment at: llvm/test/tools/llvm-objdump/relocations-in-nonreloc.test:18
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
----------------
Here's an example of what a FileHeader declaration should look like.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992