[PATCH] D72796: AMDGPU/GlobalISel: Legalize unpacked d16 image operations

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 05:45:24 PST 2020


arsenm added a comment.

In D72796#1848904 <https://reviews.llvm.org/D72796#1848904>, @nhaehnle wrote:

> Thanks, LGTM modulo the observer question -- I tend to think it's necessary, but I'll defer to your judgment.




In D72796#1848904 <https://reviews.llvm.org/D72796#1848904>, @nhaehnle wrote:

> Thanks, LGTM modulo the observer question -- I tend to think it's necessary, but I'll defer to your judgment.


I added the needed observer argument in c5fffa4da35f0fcc89b5ea88cc1bc60bc475a18e <https://reviews.llvm.org/rGc5fffa4da35f0fcc89b5ea88cc1bc60bc475a18e>, so I've fixed this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72796/new/

https://reviews.llvm.org/D72796





More information about the llvm-commits mailing list