[PATCH] D73157: AMDGPU/GlobalISel: Custom lower G_LOG/G_LOG10

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 05:17:34 PST 2020


arsenm added a comment.

In D73157#1848896 <https://reviews.llvm.org/D73157#1848896>, @nhaehnle wrote:

> LGTM relative to your other legalizer changes, though I wonder: shouldn't the old instructions be erased somehow? Other legalizer code seems to have the same problem, though I don't know how this is actually supposed to work.


Yes. I apparently fixed this already after posting


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73157/new/

https://reviews.llvm.org/D73157





More information about the llvm-commits mailing list