[PATCH] D70097: [SCEV] Add missing cache queries

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 04:12:18 PST 2020


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:2464
+    if (SCEV *S = UniqueSCEVs.FindNodeOrInsertPos(ID, IP))
+      return S;
+  }
----------------
mkazantsev wrote:
> This is not correct unless you also add no wrap flags into it.
See how it's done in `getOrCreateAddExpr`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70097/new/

https://reviews.llvm.org/D70097





More information about the llvm-commits mailing list