[PATCH] D73639: [LLVM] Wrap extern TLS variable in getter Function

[Markus Böck via Phabricator via llvm-commits]

zero9178 added a comment.

In D73639#1848892 <https://reviews.llvm.org/D73639#1848892>, @mstorsjo wrote:

> In D73639#1848054 <https://reviews.llvm.org/D73639#1848054>, @zero9178 wrote:
>
> > I also just measured compiling X86ISelLowering. Once on trunk and once with the patch applied. Using GCC 9.2 as the compiler got me 31.572, 31.843 and 31.936 for the current master and 32.241, 32.370 and 32.306 with the patch applied. So it's measurable on my machine
>
>
> I realized I had built my clang with asserts enabled, which might dilute the effect of the change. But despite disabling asserts, I can't measure any significant difference due to this change - it's almost the contrary effect, this change actually seems to make it marginally faster (both when built with GCC 7 and Clang 9).


My Machine (a Ryzen 1950X) is probably a rather exotic machine compared to others so I think it's safe to assume that your results are more representative of the real world


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73639/new/

https://reviews.llvm.org/D73639