[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:180
+    Binding: STB_GLOBAL
\ No newline at end of file

----------------
grimar wrote:
> You need to add a new line to fix "No newline at end of file" warning.
> You need to add a new line to fix "No newline at end of file" warning.
This still hasn't been addressed.


================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:159
+--- !ELF
+FileHeader: !FileHeader
+  Class: ELFCLASS32
----------------
Delete "!FileHeader". It serves no purpose. You might want to do it for the other doc in this file in a separate change too.


================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:173
+      Symbol: global
+      Type: R_386_32
+    - Offset: 0x2
----------------
Nit: Add some spaces to make the values all line up, i.e.
```
    - Offset: 0x1
      Symbol: global
      Type:   R_386_32
```

Same goes below for the other relocations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992