[PATCH] D73269: [llvm-readobj] - Add a few warnings for --gnu-hash-table.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 01:15:10 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two nits.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnuhash.test:266
+## included in the hash table can be set to the number of dynamic symbols,
+## which is one larger that the index of the last dynamic symbol.
+## For empty tables however, this value is unimportant and can be ignored.
----------------
that -> than


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2523
+    // symndx set to the number of dynamic symbols + 1 (for the zero symbol)
+    // and have the dummy null values in the Bloom filter and in the buckets
+    // vector. It happens because the value of symndx is not important for
----------------
the dummy -> dummy


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73269/new/

https://reviews.llvm.org/D73269





More information about the llvm-commits mailing list