[PATCH] D73621: [yaml2obj] - Add a way to set sh_entsize for relocation sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with suggestions.

Idle thought: I wonder if it's worth introducing some kind of command-line macro option to yaml2obj? E.g. `-DMACHINE=EM_X86_64` would replace `Machine: MACHINE` (or some similar syntax). There are a growing number of cases where we have two identical YAML blobs except for some minor difference.



================
Comment at: llvm/test/tools/yaml2obj/ELF/reloc-sec-entry-size.yaml:1
+## Test how yaml2obj set values for sh_entsize fields of relocation sections.
+
----------------
set -> sets


================
Comment at: llvm/test/tools/yaml2obj/ELF/reloc-sec-entry-size.yaml:32
+Sections:
+## Check default sh_entsizes field values.
+  - Name: .rela.default
----------------
sh_entsizes -> sh_entsize

('sh_entsize' is an adjective, so doesn't need pluralizing)


================
Comment at: llvm/test/tools/yaml2obj/ELF/reloc-sec-entry-size.yaml:39
+    Type: SHT_RELR
+## Check we can set arbitrary values to sh_entsize fields.
+  - Name:    .rela.custom
----------------
Check we can set sh_entsize fields to arbitrary values.


================
Comment at: llvm/test/tools/yaml2obj/ELF/reloc-sec-entry-size.yaml:57
+Sections:
+## Check default sh_entsizes field values.
+  - Name: .rela.default
----------------
Same as above


================
Comment at: llvm/test/tools/yaml2obj/ELF/reloc-sec-entry-size.yaml:64
+    Type: SHT_RELR
+## Check we can set arbitrary values to sh_entsize fields.
+  - Name:    .rela.custom
----------------
Same as above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73621/new/

https://reviews.llvm.org/D73621