[PATCH] D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 21:28:07 PST 2020


fpetrogalli updated this revision to Diff 241347.
fpetrogalli added a comment.
Herald added a subscriber: mgorny.

I have addressed the feedback from @jdoerfert.

In particular, the parser method now requires a Module instance. The
parser fails if the function declaration is not present in the
module. For this reason, I tweaked the test fixture in the unittest so
that the module and the function definition is present.

Notice that (as explained inthe comments in the code), for the sake of
testing, the signature of the vector function in the module is
relevant only for vector names that represent scalable functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73286/new/

https://reviews.llvm.org/D73286

Files:
  llvm/include/llvm/Analysis/VectorUtils.h
  llvm/lib/Analysis/VFABIDemangling.cpp
  llvm/lib/Analysis/VectorUtils.cpp
  llvm/lib/Transforms/Utils/ModuleUtils.cpp
  llvm/tools/vfabi-demangle-fuzzer/CMakeLists.txt
  llvm/tools/vfabi-demangle-fuzzer/vfabi-demangler-fuzzer.cpp
  llvm/unittests/Analysis/VectorFunctionABITest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73286.241347.patch
Type: text/x-patch
Size: 22099 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200130/6d90b172/attachment.bin>


More information about the llvm-commits mailing list