[llvm] 14a16fa - [llvm][NFC] Rename CallAnalyzer::onCommonInstructionSimplification

[Mircea Trofin via llvm-commits]

Author: Mircea Trofin
Date: 2020-01-29T21:07:36-08:00
New Revision: 14a16fae434a86890546e5e0364086e231e7667e

URL: https://github.com/llvm/llvm-project/commit/14a16fae434a86890546e5e0364086e231e7667e
DIFF: https://github.com/llvm/llvm-project/commit/14a16fae434a86890546e5e0364086e231e7667e.diff

LOG: [llvm][NFC] Rename CallAnalyzer::onCommonInstructionSimplification

Summary:
It is called when instructions aren't simplified, and the implementation
is expected to account for a penalty. Renamed to
onCommonInstructionMissedSimplification.

Reviewers: davidxl, eraman

Reviewed By: davidxl

Subscribers: hiraditya, baloghadamsoftware, haicheng, a.sidorin, Szelethus, donat.nagy, dkrupp, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73662

Added: 
    

Modified: 
    llvm/lib/Analysis/InlineCost.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp
index 2f2d59340b50..49014e832b88 100644
--- a/llvm/lib/Analysis/InlineCost.cpp
+++ b/llvm/lib/Analysis/InlineCost.cpp
@@ -185,7 +185,7 @@ class CallAnalyzer : public InstVisitor<CallAnalyzer, bool> {
 
   /// Called to account for any other instruction not specifically accounted
   /// for.
-  virtual void onCommonInstructionSimplification() {}
+  virtual void onMissedSimplification() {}
 
   /// Start accounting potential benefits due to SROA for the given alloca.
   virtual void onInitializeSROAArg(AllocaInst *Arg) {}
@@ -502,7 +502,7 @@ class InlineCostCallAnalyzer final : public CallAnalyzer {
 
     addCost(SwitchCost, (int64_t)CostUpperBound);
   }
-  void onCommonInstructionSimplification() override {
+  void onMissedSimplification() override {
     addCost(InlineConstants::InstrCost);
   }
 
@@ -1761,7 +1761,7 @@ CallAnalyzer::analyzeBlock(BasicBlock *BB,
     if (Base::visit(&*I))
       ++NumInstructionsSimplified;
     else
-      onCommonInstructionSimplification();
+      onMissedSimplification();
 
     using namespace ore;
     // If the visit this instruction detected an uninlinable pattern, abort.