[PATCH] D73235: [GlobalMerge] Preserve symbol visibility when merging globals

Wed Jan 29 20:08:34 PST 2020

vvereschaka added a comment.

Hi @mspang, @hans,

the `CodeGen/AArch64/global-merge-hidden-minsize.ll` test gets failed on aarch64 builder
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3704/steps/test-check-llvm/logs/FAIL%3A%20LLVM%3A%3Aglobal-merge-hidden-minsize.ll

with the following error:

  error: unable to get target for 'arm-none-linux-gnu', see --version and --triple.

This is Aarch64 only builder without supporting for Arm32 triples. The test is inside Aarch64 specific test folder, but it also uses Arm32 triple.
Would you split this test and put the Arm32 specific part into `CodeGen/ARM`?

Thanks.
Vlad.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73235/new/

https://reviews.llvm.org/D73235