[PATCH] D73550: Prevent building with MSVC 14.24

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D73550#1848010 <https://reviews.llvm.org/D73550#1848010>, @mehdi_amini wrote:

> I have concern with this patch: this is a big hammer that blocks building *anything* using LLVM even if it does not involve any of the code path that is problematic.


How can you tell which parts of the code are affected by this miscompilation? I've seen occasionally crashes in opt which only occur for this version of MSVC. I fear that people would lose time investigating indirect bugs caused by this.

> I would rather see this implemented as a CMake check and a flag that can override/disable the check.

Do you see this as an issue for end-users/consumers of LLVM? Or just for LLVM developers? One can simply disable this check locally, given that 16.5 will be released soon; or use clang-cl 9.0.1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73550/new/

https://reviews.llvm.org/D73550