[PATCH] D73640: [SmallString] Add explicit conversion to std::string

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 13:49:55 PST 2020


JDevlieghere added a comment.

In D73640#1847990 <https://reviews.llvm.org/D73640#1847990>, @cishida wrote:

> This indirection seems like unnecessary work. Could you reimplement this as a direct conversion to `std::string`?


Good catch, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73640/new/

https://reviews.llvm.org/D73640





More information about the llvm-commits mailing list