[PATCH] D72454: [AIX] Enable frame pointer for AIX and add related test suite

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm added a comment.

Some early issues.  I need more time to go through the AIX assembly in detail to ensure it's correct.



================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca-with-func-call.ll:7
+
+; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc64-unknown-linux-gnu | \
+; RUN: FileCheck %s -check-prefix=PPC64-LINUX
----------------
There is trailing whitespace after the \ in the patch.  2 occurrences detected when I applied the patch.


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca-with-func-call.ll:13
+
+; RUN: not llc -verify-machineinstrs < %s -mcpu=pwr4 -mattr=-altivec \
+; RUN: -mtriple=powerpc-ibm-aix-xcoff 2>&1 | FileCheck %s \
----------------
I expect there is a dependency on D73209, which adds the stack arg work.  Perhaps it's cleaner if we make this patch dependent on that so that we can avoid churn.


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca-with-func-call.ll:69
+; PPC32-LINUX: stw 11, 24(31)
+; PPC32-LINUX: stwux
+; PPC32-LINUX: stwux
----------------
are these stwux deliberately omitting the operands?


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca.ll:35
+; PPC32-LINUX-LABEL: f1
+; PPC32-LINUX: stwu 1, -32(1)
+; PPC32-LINUX-NEXT: slwi 3, 3, 2
----------------
I find it useful to insert whitespace to line up the assembly text.


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca.ll:52
+; PPC64-LINUX-LABEL: f1
+; PPC64-LINUX: std 31, -8(1)
+; PPC64-LINUX-NEXT: stdu 1, -64(1)
----------------
whitespace


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca.ll:70
+; PPC32-AIX-LABEL: f1
+; PPC32-AIX: stw 31, -4(1)
+; PPC32-AIX-NEXT: stwu 1, -48(1)
----------------
whitespace


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-dyn-alloca.ll:85
+; PPC64-AIX-LABEL: f1
+; PPC64-AIX: std 31, -8(1)
+; PPC64-AIX-NEXT: stdu 1, -64(1)
----------------
whitespace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72454/new/

https://reviews.llvm.org/D72454