[PATCH] D73639: [LLVM] Wrap extern TLS variable in getter Function

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D73639#1847333 <https://reviews.llvm.org/D73639#1847333>, @russell.gallop wrote:

> > Additionally it allows Clang versions prior to 10 to compile current trunk.
>
> I have been using Clang prior to 10 to compile without this change. Do you mean with BUILD_SHARED_LIBS for this as well?


He meant when targeting mingw. There were issues with code generation for mingw targets, when accessing one TLS variable from multiple object files but that's fixed in the 10.0 branch and master.

But one can't access a TLS variable directly from a different DLL (as before with `extern LLVM_THREAD_LOCAL`) at all, which would be necessary when building with BUILD_SHARED_LIBS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73639/new/

https://reviews.llvm.org/D73639