[PATCH] D73595: [mlir][Linalg][doc] Add Design Document for the Linalg Dialect

Albert Cohen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 08:44:09 PST 2020


albertcohen accepted this revision.
albertcohen added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you for taking the time to dump this background document. This is a huge piece of work as a rationale and vision for linalg, and code generation for tensor libraries in MLIR.

There are a few aspects I'd like to organize differently, like splitting out a top level documentation paragraph and moving it to the tablegen description where the rest of the documentation lives, renaming the rest as a rationale document (pointing to it in the doc), and modularizing the rationale a bit more. I will suggest something in a separate commit and also propose minor revisions to the technical presentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73595/new/

https://reviews.llvm.org/D73595





More information about the llvm-commits mailing list