[PATCH] D72829: Implement -fsemantic-interposition

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

In D72829#1846353 <https://reviews.llvm.org/D72829#1846353>, @arichardson wrote:

> As this is user-facing documentation I feel like there should be a slightly longer explaning what the option does.


+1 on this, otherwise LGTM. Thanks for implementing this!



================
Comment at: llvm/include/llvm/IR/GlobalValue.h:426
   /// Return true if this global's definition can be substituted with an
   /// *arbitrary* definition at link time.  We cannot do any IPO or inlinining
   /// across interposable call edges, since the callee can be replaced with
----------------
Minor nit: We have extended this to now determine if a definition can be substituted with an arbitrary definition at link time or load time. 

I would suggest changing the first `link time` to `link time or load time`, and changing
`since the callee can be replaced with something arbitrary at link time.` to 
`since the callee can be replaced with something arbitrary.`,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72829/new/

https://reviews.llvm.org/D72829