[PATCH] D73582: [AMDGPU] override isHighLatencyDef

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 07:49:12 PST 2020


rampitec added a comment.

In D73582#1846426 <https://reviews.llvm.org/D73582#1846426>, @foad wrote:

> I have no objection to this patch, but I'm not sure isHighLatencyDef will ever be called by generic code. I think the latency information ususally comes from the sched model instead. Also note that TargetInstrInfo::defaultDefLatency never calls isHighLatencyDef on a load instruction!


Yes, I think this is mostly NFC. It is just confusing to have a very similar method and do not override a generic one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73582/new/

https://reviews.llvm.org/D73582





More information about the llvm-commits mailing list