[PATCH] D73627: [DebugInfo] Fix dumping CIE ID in .eh_frame sections.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 07:03:35 PST 2020


ikudrin created this revision.
ikudrin added reviewers: probinson, dblaikie, aprantl.
ikudrin added projects: LLVM, debug-info.
Herald added subscribers: luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, rupprecht, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: jhenderson.

We do not keep the actual value of the `CIE_id` field, because it is predefined, and use a constant when dumping a CIE record. The issue was that the predefined value is different for `.debug_frame` and `.eh_frame` sections, but we always printed the same. The patch fixes that by choosing an appropriate constant to print.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73627

Files:
  lld/test/ELF/eh-frame-hdr-augmentation.s
  llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
  llvm/test/DebugInfo/RISCV/eh-frame.s
  llvm/test/MC/Mips/eh-frame.s
  llvm/test/MC/X86/return-column.s
  llvm/test/tools/llvm-dwarfdump/X86/eh-frame-return-address-reg.s
  llvm/test/tools/llvm-objdump/eh_frame-arm64.test
  llvm/test/tools/llvm-objdump/eh_frame-coff.test
  llvm/test/tools/llvm-objdump/eh_frame-mipsel.test
  llvm/test/tools/llvm-objdump/eh_frame_zero_cie.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73627.241142.patch
Type: text/x-patch
Size: 5813 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200129/7a704a70/attachment.bin>


More information about the llvm-commits mailing list