[PATCH] D73011: [opt viewer] Python compat - decode/encode string

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 07:39:56 PST 2020


ychen added a comment.

In D73011#1846419 <https://reviews.llvm.org/D73011#1846419>, @serge-sans-paille wrote:

> @ychen I summarized the situation in http://lists.llvm.org/pipermail/llvm-dev/2020-January/138730.html , but according to the documentation, https://llvm.org/docs/GettingStarted.html#id7 we still support python2.7 ...


@serge-sans-paille io.open is supported since 2.6 https://docs.python.org/2/library/io.html#module-interface. I did test that the patch works for both 2.7 and >3. I saw some failures with the Unicode problem without this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73011/new/

https://reviews.llvm.org/D73011





More information about the llvm-commits mailing list