[PATCH] D72931: AMDGPU: Add a16 feature to gfx10

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:3679
+      unsigned AddrWords = IsA16 ? (AddrComponents + 1) / 2 : AddrComponents;
+
       unsigned VAddrWords;
----------------
sebastian-ne wrote:
> I think this should be the following because the extra arguments like bias are still f32 and should not be divided by two:
> 
>       unsigned AddrComponents =
>                            (BaseOpcode->Gradients ? Dim->NumGradients : 0) +
>                            (BaseOpcode->Coordinates ? Dim->NumCoords : 0) +
>                            (BaseOpcode->LodOrClampOrMip ? 1 : 0);
> 
>       unsigned AddrWords = BaseOpcode->NumExtraArgs +
>                            (IsA16 ? (AddrComponents + 1) / 2 : AddrComponents);
Feel free to commandeer, I'm probably not going to get back to fixing the DAG version anytime soon 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72931/new/

https://reviews.llvm.org/D72931