[PATCH] D73460: [RDA][ARM] Move functionality into RDA

[Sam Parker via Phabricator via llvm-commits]

samparker marked 2 inline comments as done.
samparker added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:120
 
+  bool hasLocalDefBefore(MachineInstr *MI, int PhysReg) const;
+
----------------
SjoerdMeijer wrote:
> nit: missing comment/description
I'll add it before committing.


================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:188
+
+  /// Utility function for isSafeToMoveForwards/Backwards.
+  template<typename Iterator>
----------------
SjoerdMeijer wrote:
> nit: if this is only a helper for isSafeToMoveForwards/Backwards, should this be a private function?
It is!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73460/new/

https://reviews.llvm.org/D73460