[PATCH] D73465: Add gpu::LaunchOp::addKernelArgument.

Tue Jan 28 20:54:34 PST 2020

mehdi_amini added a comment.

In D73465#1844126 <https://reviews.llvm.org/D73465#1844126>, @herhut wrote:

> In D73465#1843770 <https://reviews.llvm.org/D73465#1843770>, @mehdi_amini wrote:
>
> > > Code motion into a gpu::LaunchOp region requires operands of moved instructions to be threaded through operands of the gpu.launch to ensure that the gpu.launch remaines closed from above.
> >
> > Can we revisit lifting this requirement? This was something that was raised from the beginning of the development of this op.
>
>
> Should we just lift the requirement or completely forego the concept of passing arguments into the launch? Just lifting the requirement would be less of a breaking change but there is no good use of having the operands.

Right: I'm not sure what is the use for having the operands at all?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73465/new/

https://reviews.llvm.org/D73465