[PATCH] D73509: [MachineScheduler] relax successor chain on clustering

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 10:49:13 PST 2020


rampitec added a comment.

In D73509#1844150 <https://reviews.llvm.org/D73509#1844150>, @foad wrote:

> This doesn't fix the problem that inspired D71717 <https://reviews.llvm.org/D71717>. Consider the first test case in `memory_clause.ll`. With baseline llvm I get:
>
>   $ bin/llc -march=amdgcn -mcpu=gfx902 -verify-machineinstrs -amdgpu-enable-global-sgpr-addr -o /dev/null ~/git/llvm-project/llvm/test/CodeGen/AMDGPU/memory_clause.ll -debug-only=machine-scheduler |& egrep "^Cluster|Machine code for function"
>   # Machine code for function vector_clause: NoPHIs, TracksLiveness
>   Cluster ld/st SU(2) - SU(3)
>   Cluster ld/st SU(6) - SU(7)
>   Cluster ld/st SU(8) - SU(9)
>   Cluster ld/st SU(11) - SU(13)
>   # Machine code for function vector_clause: NoPHIs, TracksLiveness


My problem is I cannot reproduce it. All I have is

  # Machine code for function vector_clause: NoPHIs, TracksLiveness
  Cluster ld/st SU(2) - SU(3)
  # Machine code for function vector_clause: NoPHIs, TracksLiveness

It just does not try to cluster all global loads and stores at all! It also does not do it even with D71717 <https://reviews.llvm.org/D71717>.
I will debug it...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73509/new/

https://reviews.llvm.org/D73509





More information about the llvm-commits mailing list