[PATCH] D73575: [InstCombine] canonicalize splat shuffle after cmp

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 13:11:09 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

Does it make sense to extend this for arbitrary shuffles in the future? The mask construction logic in https://github.com/llvm/llvm-project/blob/4aa8cdfeebec115b928e0ccb452551b520d00f0b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp#L1612-L1660 can probably mostly be reused for the icmp case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73575/new/

https://reviews.llvm.org/D73575





More information about the llvm-commits mailing list