[PATCH] D73560: [llvm-readobj] - Don't crash when dumping invalid dynamic relocation.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 09:40:52 PST 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar added a parent revision: D73484: [llvm-readobj] - Improve error message reported by DynRegionInfo..

Currently when we dump dynamic relocation with use of
DT_RELA/DT_RELASZ/DT_RELAENT tags, we crash when a symbol index
is larger than the number of dynamic symbols or
when there is no dynamic symbol table.

This patch adds test cases and fixes the issues.
It is rebased on top of D73484 <https://reviews.llvm.org/D73484>.


https://reviews.llvm.org/D73560

Files:
  llvm/test/tools/llvm-readobj/ELF/broken-dynamic-reloc.test
  llvm/test/tools/llvm-readobj/ELF/dynamic-reloc-no-section-headers.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73560.240910.patch
Type: text/x-patch
Size: 8827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200128/274dd1e5/attachment-0001.bin>


More information about the llvm-commits mailing list