[PATCH] D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer.

pierre gousseau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 09:35:50 PST 2020


pgousseau added a comment.

In D73475#1843805 <https://reviews.llvm.org/D73475#1843805>, @craig.topper wrote:

> Is this subject to the same problem as PR42064?


Thanks for pointing this issue, yes I believe this change will have the same problem in cases where stack realignment occurs after mwaitx pseudo instruction is generated.
If I understand the conclusion of the PR is that the decision to save/restore base pointer needs to be done after PEI? I will try that approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73475/new/

https://reviews.llvm.org/D73475





More information about the llvm-commits mailing list