[PATCH] D72526: [Matrix] Mark expressions shared between multiple remarks.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 09:26:19 PST 2020


fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1123
+      assert(SI != Shared.end());
+      if (SI->second.size() > 1 && !ParentShared) {
+        for (Value *S : SI->second) {
----------------
anemet wrote:
> Do we even need to run find if ParentShared?
Not really. I've moved the find in the if().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72526/new/

https://reviews.llvm.org/D72526





More information about the llvm-commits mailing list