[PATCH] D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 08:34:25 PST 2020


yamauchi marked an inline comment as done.
yamauchi added inline comments.


================
Comment at: llvm/lib/Analysis/Loads.cpp:487
+
       // If we have alias analysis and it says the store won't modify the loaded
       // value, ignore the store.
----------------
xbolva00 wrote:
> else {
> 
> 
> ?
Do you mean it'd be good to combine the two if statements?

```
if (!AA) {
  // ...
  if (AreNonOverlapSameBaseLoadAndStore(..))
    continue;
} else {
  // ...
  if (!isModSet(AA->getModRefInfo(SI, StrippedPtr, AccessSize)))
    continue;
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71307/new/

https://reviews.llvm.org/D71307





More information about the llvm-commits mailing list