[PATCH] D73507: [scudo][standalone] Secondary & general other improvements

Tue Jan 28 07:08:37 PST 2020

cryptoad marked an inline comment as done.
cryptoad added inline comments.

================
Comment at: compiler-rt/lib/scudo/standalone/flags.inc:48

-SCUDO_FLAG(int, release_to_os_interval_ms, 5000,
+SCUDO_FLAG(int, release_to_os_interval_ms, SCUDO_ANDROID ? 1000 : 5000,
            "Interval (in milliseconds) at which to attempt release of unused "
----------------
cryptoad wrote:
> pcc wrote:
> > hctim wrote:
> > > Given that this might get very complicated if you wanted to introduce different defaults for different platforms - it may be worth adding a TODO to initialise Scudo as part of `libc_init_malloc` rather than rely on lazy-initialisation.
> > I would prefer if we moved towards making these things static (e.g. part of AndroidConfig et al) rather than configurable via environment variables.
> Ack. Technically a platform could also use the SCUDO_DEFAULT_OPTIONS define at compile time.
I think making it part of the configuration is a good idea once we get a way to change it at runtime which is coming up with the mallopt change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73507/new/

https://reviews.llvm.org/D73507