[PATCH] D73447: AMDGPU/GlobalISel: Legalize non-a16 non-NSA images

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 07:01:27 PST 2020


arsenm added a comment.

In D73447#1842423 <https://reviews.llvm.org/D73447#1842423>, @nhaehnle wrote:

> I guess the same question applies here as to the other change: Why is this a legalization change and not an instruction selection one?


The legalizer's job is to get instructions to have the right operand types. If we expanded this in instruction selection, we wouldn't get the combining benefit of the pack/unpack instructions (and they could be inside a waterfall loop inserted during RegBankSelect)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73447/new/

https://reviews.llvm.org/D73447





More information about the llvm-commits mailing list