[PATCH] D73383: Allow retrieving source files relative to the compilation directory.

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 09:33:00 PST 2020


saugustine added a comment.

The enum is present only in an assert because as the code is written, it works as, an "other" case. It is something a client would pass, and right now there are no clients inside llvm. I guess I could add one to the symbolizer.

As I mentioned in the original message, I would love to add a test case for this, but I'm not sure where. The rest of the code isn't explicitly tested except by indirectly by way of symbolizer tests. So I guess I can go that route.

What flag would you like? Absolute is the symbolizer default, and "-s" makes it report basenames only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73383/new/

https://reviews.llvm.org/D73383





More information about the llvm-commits mailing list